Protect: Update Threat Icons #40621

nateweller · 2024-12-15T19:59:13Z

Proposed changes:

Home: Use a red error state in the stat card when there are threats detected.
Scan: Use the fill variants with color to better emphasize the good/bad results.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Review the icons in Protect.

Screenshots

github-actions · 2024-12-15T20:00:21Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Protect plugin:

Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

dkmyta

Nice enhancement!

A conflict still appears to need fixing in the ScanPage component.

We now display the same icon in the HomePage scan card for errors and threats - what if we took a similar approach as the ErrorAdminSectionHero and made the error icon outlined? Just to add some variation between the two:

projects/plugins/protect/src/js/routes/scan/index.jsx

projects/plugins/protect/src/js/routes/home/home-statcards.jsx

nateweller · 2024-12-17T23:33:22Z

We now display the same icon in the HomePage scan card for errors and threats - what if we took a similar approach as the ErrorAdminSectionHero and made the error icon outlined? Just to add some variation between the two:

Added outline variant here: #40621 (comment)

Protect: Add Go to Cloud and Scan now button to Protect primary header (#40057) Protect: Update Scan and History headers (#40058) Protect: de-emphasize cloud link by using link variant (#40211) Protect: Add ShieldIcon Component (#40402) Protect: Integrate ThreatsDataViews Component (#40076) Components: Add ScanReport (#40419) Protect: Refactor AdminSectionHero (#40516) Protect: Update Scan History extension types (#40548) Protect: Add Home page (#40317) Protect: Integrate ScanReport (#40420) ScanReport: Fix defaultLayout (#40603) Update onboarding popover placement (#40550) Protect Meets Core: Home Page Scan Report Data Adjustments (#40616) Scan Report: Align Status Icon (#40617) Apply max width to hero content (#40618) Protect: Hide Scan Report When No Data (#40619) Protect: Hide Threats Report When No Data (#40620) Protect: Update Threat Icons (#40621) Protect: fix home page stat card spacing (#40623) ScanReport: Disable hiding relevant fields (#40602) Use error variant (#40832) Protect: Restore HistoryAdminSectionHero (#40551) Protect: Separate scan results and history DataViews (#40845) ThreatsDataViews: Improve responsiveness (#40670) ThreatsDataViews: ThreatModal integration (#40202) Protect Meets Core: Fix "0" rendered by conditional render chain (#40882)

nateweller self-assigned this Dec 15, 2024

nateweller requested a review from a team December 15, 2024 19:59

nateweller added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Dec 15, 2024

nateweller marked this pull request as ready for review December 15, 2024 19:59

github-actions bot added [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress labels Dec 15, 2024

nateweller force-pushed the update/protect/hide-threat-results-when-no-data branch from c0531a2 to dd590ac Compare December 16, 2024 01:58

nateweller force-pushed the update/protect/threat-icons branch from 82263e8 to b5020dd Compare December 16, 2024 02:00

nateweller force-pushed the update/protect/hide-threat-results-when-no-data branch from dd590ac to e2349ad Compare December 16, 2024 03:22

nateweller force-pushed the update/protect/threat-icons branch from b5020dd to dd8fb7f Compare December 16, 2024 03:23

nateweller force-pushed the update/protect/hide-threat-results-when-no-data branch from e2349ad to 1850b0c Compare December 16, 2024 04:11

nateweller force-pushed the update/protect/threat-icons branch from dd8fb7f to 37c57b3 Compare December 16, 2024 04:14

nateweller force-pushed the update/protect/hide-threat-results-when-no-data branch 5 times, most recently from 345330f to 838b060 Compare December 16, 2024 07:29

nateweller force-pushed the update/protect/threat-icons branch from 37c57b3 to de0a8c3 Compare December 16, 2024 16:29

dkmyta suggested changes Dec 16, 2024

View reviewed changes

projects/plugins/protect/src/js/routes/scan/index.jsx Outdated Show resolved Hide resolved

dkmyta mentioned this pull request Dec 16, 2024

Protect: fix home page stat card spacing #40623

Merged

3 tasks

nateweller commented Dec 17, 2024

View reviewed changes

projects/plugins/protect/src/js/routes/scan/index.jsx Outdated Show resolved Hide resolved

nateweller commented Dec 17, 2024

View reviewed changes

projects/plugins/protect/src/js/routes/home/home-statcards.jsx Outdated Show resolved Hide resolved

nateweller requested a review from dkmyta December 17, 2024 23:33

nateweller removed the [Status] In Progress label Dec 17, 2024

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Dec 17, 2024

nateweller added 2 commits December 17, 2024 16:35

Init project branch

b04eeff

Protect: minor enhancements to scan report data

eba4892

Base automatically changed from update/protect/hide-threat-results-when-no-data to add/protect/core December 18, 2024 20:18

Merge branch 'add/protect/core' into update/protect/threat-icons

7a374a5

nateweller merged commit 4fa70a3 into add/protect/core Dec 18, 2024
11 of 13 checks passed

nateweller deleted the update/protect/threat-icons branch December 18, 2024 20:19

nateweller added a commit that referenced this pull request Dec 18, 2024

Protect: Update Threat Icons (#40621)

e971448

github-actions bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Dec 18, 2024

nateweller added a commit that referenced this pull request Dec 26, 2024

Protect: Update Threat Icons (#40621)

506ecb2

nateweller added a commit that referenced this pull request Dec 31, 2024

Protect: Update Threat Icons (#40621)

97f5c59

nateweller added a commit that referenced this pull request Jan 6, 2025

Protect: Update Threat Icons (#40621)

bb6b8b2

nateweller added a commit that referenced this pull request Jan 12, 2025

Protect: Update Threat Icons (#40621)

133a718

nateweller added a commit that referenced this pull request Jan 14, 2025

Protect: Update Threat Icons (#40621)

15f225f

nateweller added a commit that referenced this pull request Jan 22, 2025

Protect: Update Threat Icons (#40621)

ee31fd3

nateweller added a commit that referenced this pull request Jan 27, 2025

Protect: Update Threat Icons (#40621)

a4f4b92

nateweller added a commit that referenced this pull request Jan 31, 2025

Protect: Update Threat Icons (#40621)

6c5414d

nateweller added a commit that referenced this pull request Feb 3, 2025

Protect: Update Threat Icons (#40621)

39556a7

nateweller added a commit that referenced this pull request Feb 4, 2025

Protect: Update Threat Icons (#40621)

034dd55

nateweller added a commit that referenced this pull request Feb 5, 2025

Protect: Update Threat Icons (#40621)

b66fd9a

nateweller added a commit that referenced this pull request Feb 9, 2025

Protect: Update Threat Icons (#40621)

3f47863

nateweller added a commit that referenced this pull request Feb 9, 2025

Protect: Update Threat Icons (#40621)

fe9d633

nateweller added a commit that referenced this pull request Feb 22, 2025

Protect: Update Threat Icons (#40621)

1b42f55

nateweller added a commit that referenced this pull request Mar 18, 2025

Protect: Update Threat Icons (#40621)

ea4af61

nateweller added a commit that referenced this pull request Mar 22, 2025

Protect: Update Threat Icons (#40621)

f0dfecd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Protect: Update Threat Icons #40621

Protect: Update Threat Icons #40621

Uh oh!

nateweller commented Dec 15, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 15, 2024

Uh oh!

dkmyta left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nateweller commented Dec 17, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Protect: Update Threat Icons #40621

Protect: Update Threat Icons #40621

Uh oh!

Conversation

nateweller commented Dec 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Screenshots

Uh oh!

github-actions bot commented Dec 15, 2024

Uh oh!

dkmyta left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nateweller commented Dec 17, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nateweller commented Dec 15, 2024 •

edited

Loading

dkmyta left a comment •

edited

Loading