-
-
Notifications
You must be signed in to change notification settings - Fork 755
feat(semantic/scoping): add declaration and flags fields for Redeclaraion
#10060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
03-26-feat_semantic_scoping_add_declaration_and_flags_fields_for_symbol_declarations
Mar 28, 2025
Merged
feat(semantic/scoping): add declaration and flags fields for Redeclaraion
#10060
graphite-app
merged 1 commit into
main
from
03-26-feat_semantic_scoping_add_declaration_and_flags_fields_for_symbol_declarations
Mar 28, 2025
+24
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
CodSpeed Instrumentation Performance ReportMerging #10060 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
2df4aa0 to
ceebcc0
Compare
ac9d13f to
18689d0
Compare
This was referenced Mar 26, 2025
Contributor
Merge activity
|
…claraion (#10060) `declaration` and `flags` are also fields of the symbol. Before, we only had a span info in `symbol_redeclarations`, which means we have no way to know what the redeclaration AST node is and what the symbol flags is
ceebcc0 to
b804f7c
Compare
18689d0 to
528469e
Compare
Base automatically changed from
03-26-feat_semantic_introduce_redeclaraion_for_symbol_declarations
to
main
March 28, 2025 04:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

declarationandflagsare also fields of the symbol. Before, we only had a span info insymbol_redeclarations, which means we have no way to know what the redeclaration AST node is and what the symbol flags is