fix(semantic): define a variable in a function expression whose name is the same as the function name which is considered a redeclaration

[Dunqing]

(function n(n) {})()

The function n symbol will insert into the function itself scope, which causes param n to be considered a redeclaration, but it is not.

[Dunqing]

• feat(semantic): add symbol_id for declare class binding #10095
• refactor(semantic): align handling of declaring symbol for class with TypeScript #10094
• feat(semantic): check redeclaration of function declaration and class declaration #10093
• feat(semantic): add symbol_id for declare function binding #10078
• refactor(semantic): align handling of declaring symbol for function with TypeScript #10086
• feat(semantic): check redeclaration of variable declaration and function declaration in the block scope #10074
• fix(semantic): define a variable in a function expression whose name is the same as the function name which is considered a redeclaration #10077 👈 (View in Graphite)
• refactor(semantic)!: store symbol information as the first entry in symbol_declarations when it is redeclared #10062
• feat(semantic/scoping): add declaration and flags fields for Redeclaraion #10060
• feat(semantic): introduce Redeclaraion for Scoping::symbol_declarations #10059
• perf(semantic): use FxHashMap to replace IndexVec for symbol_redeclarations #10058
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10077 will create unknown performance changes

_{Comparing 03-27-fix_semantic_define_a_variable_in_a_function_expression_whose_name_is_the_same_as_the_function_name_which_is_considered_a_redeclaration (6687f5b) with main (b804f7c)}

Summary

🆕 33 new benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
🆕	codegen[checker.ts]	N/A	22.6 ms	N/A
🆕	codegen_sourcemap[checker.ts]	N/A	65.6 ms	N/A
🆕	isolated-declarations[vue-id.ts]	N/A	58.3 ms	N/A
🆕	lexer[RadixUIAdoptionSection.jsx]	N/A	21.1 µs	N/A
🆕	lexer[antd.js]	N/A	24.8 ms	N/A
🆕	lexer[cal.com.tsx]	N/A	5.9 ms	N/A
🆕	lexer[checker.ts]	N/A	14.8 ms	N/A
🆕	lexer[pdf.mjs]	N/A	3.9 ms	N/A
🆕	linter[RadixUIAdoptionSection.jsx]	N/A	2.7 ms	N/A
🆕	linter[cal.com.tsx]	N/A	1.2 s	N/A
🆕	linter[checker.ts]	N/A	3 s	N/A
🆕	mangler[antd.js]	N/A	16 ms	N/A
🆕	mangler[react.development.js]	N/A	294.5 µs	N/A
🆕	mangler[typescript.js]	N/A	39.7 ms	N/A
🆕	minifier[antd.js]	N/A	165.6 ms	N/A
🆕	minifier[react.development.js]	N/A	1.8 ms	N/A
🆕	minifier[typescript.js]	N/A	291.6 ms	N/A
🆕	estree[checker.ts]	N/A	96.1 ms	N/A
🆕	parser[RadixUIAdoptionSection.jsx]	N/A	92.4 µs	N/A
🆕	parser[antd.js]	N/A	113.5 ms	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[graphite-app]

Merge activity

• Mar 28, 12:11 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Mar 28, 12:29 AM EDT: A user merged this pull request with the Graphite merge queue.