feat(semantic): check redeclaration of variable declaration and function declaration in the block scope #10074

Dunqing · 2025-03-27T10:04:42Z

close: #10050
close: #10051
close: #10055
close: #10056

This PR causes a lot of test262 tests to fail, all are expected. The reason is that the test262 test runner has a little incorrect, see #10057. And also produces a lot of duplicate errors, which will be removed in #10078.

Dunqing · 2025-03-27T10:05:00Z

feat(semantic): add symbol_id for declare class binding #10095
refactor(semantic): align handling of declaring symbol for class with TypeScript #10094
feat(semantic): check redeclaration of function declaration and class declaration #10093
feat(semantic): add symbol_id for declare function binding #10078
refactor(semantic): align handling of declaring symbol for function with TypeScript #10086
feat(semantic): check redeclaration of variable declaration and function declaration in the block scope #10074 👈 (View in Graphite)
fix(semantic): define a variable in a function expression whose name is the same as the function name which is considered a redeclaration #10077
refactor(semantic)!: store symbol information as the first entry in symbol_declarations when it is redeclared #10062
feat(semantic/scoping): add declaration and flags fields for Redeclaraion #10060
feat(semantic): introduce Redeclaraion for Scoping::symbol_declarations #10059
perf(semantic): use FxHashMap to replace IndexVec for symbol_redeclarations #10058
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-03-27T10:10:34Z

CodSpeed Instrumentation Performance Report

Merging #10074 will not alter performance

_{Comparing 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope (370266c) with main (2720204)}

Summary

✅ 33 untouched benchmarks

apps/oxlint/fixtures/import/test.js

graphite-app · 2025-03-28T07:25:08Z

Merge activity

Mar 28, 3:25 AM EDT: Boshen added this pull request to the Graphite merge queue.
Mar 28, 3:42 AM EDT: A user merged this pull request with the Graphite merge queue.

…ion declaration in the block scope (#10074) close: #10050 close: #10051 close: #10055 close: #10056 This PR causes a lot of test262 tests to fail, all are expected. The reason is that the test262 test runner has a little incorrect, see #10057. And also produces a lot of duplicate errors, which will be removed in #10078.

…ith TypeScript (#10086) The `Symbol` is based on the `TypeScript` implementation, but `TypeScript` doesn't support non-strict mode. So we tweaked the implementation to support non-strict mode before, but that held us back from adding symbol id for `declare function`, because `declare function oxc(): number; declare function oxc(): void` is valid, but we have no idea except introducing more symbol flags by to check whether it is a declare function. But introducing more symbol flags will lead to greater discrepancies between our implementation and `TypeScript`. #10074 has re-implemented the function redeclaration check in `checker` so that this PR can make a change to align with `TypeScript` implementation without leading to unexpected errors. A lot of error messages are removed in snapshots, because they are all duplicated, which was introduced by #10074

…ion declaration in the block scope (#10074) close: #10050 close: #10051 close: #10055 close: #10056 This PR causes a lot of test262 tests to fail, all are expected. The reason is that the test262 test runner has a little incorrect, see #10057. And also produces a lot of duplicate errors, which will be removed in #10078.

…ith TypeScript (#10086) The `Symbol` is based on the `TypeScript` implementation, but `TypeScript` doesn't support non-strict mode. So we tweaked the implementation to support non-strict mode before, but that held us back from adding symbol id for `declare function`, because `declare function oxc(): number; declare function oxc(): void` is valid, but we have no idea except introducing more symbol flags by to check whether it is a declare function. But introducing more symbol flags will lead to greater discrepancies between our implementation and `TypeScript`. #10074 has re-implemented the function redeclaration check in `checker` so that this PR can make a change to align with `TypeScript` implementation without leading to unexpected errors. A lot of error messages are removed in snapshots, because they are all duplicated, which was introduced by #10074

…ion declaration in the block scope (#10074) close: #10050 close: #10051 close: #10055 close: #10056 This PR causes a lot of test262 tests to fail, all are expected. The reason is that the test262 test runner has a little incorrect, see #10057. And also produces a lot of duplicate errors, which will be removed in #10078.

…ith TypeScript (#10086) The `Symbol` is based on the `TypeScript` implementation, but `TypeScript` doesn't support non-strict mode. So we tweaked the implementation to support non-strict mode before, but that held us back from adding symbol id for `declare function`, because `declare function oxc(): number; declare function oxc(): void` is valid, but we have no idea except introducing more symbol flags by to check whether it is a declare function. But introducing more symbol flags will lead to greater discrepancies between our implementation and `TypeScript`. #10074 has re-implemented the function redeclaration check in `checker` so that this PR can make a change to align with `TypeScript` implementation without leading to unexpected errors. A lot of error messages are removed in snapshots, because they are all duplicated, which was introduced by #10074

Dunqing mentioned this pull request Mar 27, 2025

refactor(semantic)!: store symbol information as the first entry in symbol_declarations when it is redeclared #10062

Merged

github-actions bot added A-semantic Area - Semantic C-enhancement Category - New feature or request labels Mar 27, 2025

Dunqing changed the base branch from 03-26-refactor_semantic_store_symbol_information_as_the_first_entry_in_symbol_declarations_when_it_is_redeclared to graphite-base/10074 March 27, 2025 12:24

Dunqing force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from 9e394ed to 40f0f10 Compare March 27, 2025 12:24

Dunqing changed the base branch from graphite-base/10074 to 03-27-fix_semantic_define_a_variable_in_a_function_expression_whose_name_is_the_same_as_the_function_name_which_is_considered_a_redeclaration March 27, 2025 12:24

Dunqing mentioned this pull request Mar 27, 2025

fix(semantic): define a variable in a function expression whose name is the same as the function name which is considered a redeclaration #10077

Merged

Dunqing force-pushed the 03-27-fix_semantic_define_a_variable_in_a_function_expression_whose_name_is_the_same_as_the_function_name_which_is_considered_a_redeclaration branch from abe9931 to fd0b8eb Compare March 27, 2025 12:31

Dunqing force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch 2 times, most recently from bee4271 to 1c741db Compare March 27, 2025 12:42

Dunqing mentioned this pull request Mar 27, 2025

feat(semantic): add symbol_id for declare function binding #10078

Merged

Dunqing force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from 1c741db to e81ae1e Compare March 27, 2025 14:12

github-actions bot added the A-cli Area - CLI label Mar 27, 2025

Dunqing commented Mar 27, 2025

View reviewed changes

apps/oxlint/fixtures/import/test.js Show resolved Hide resolved

Dunqing marked this pull request as ready for review March 27, 2025 14:30

Dunqing requested a review from Boshen as a code owner March 27, 2025 14:30

Dunqing mentioned this pull request Mar 28, 2025

refactor(semantic): align handling of declaring symbol for function with TypeScript #10086

Merged

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025

graphite-app bot changed the base branch from 03-27-fix_semantic_define_a_variable_in_a_function_expression_whose_name_is_the_same_as_the_function_name_which_is_considered_a_redeclaration to graphite-base/10074 March 28, 2025 04:14

graphite-app bot force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from e81ae1e to 50b2970 Compare March 28, 2025 04:29

graphite-app bot force-pushed the graphite-base/10074 branch from fd0b8eb to 6687f5b Compare March 28, 2025 04:29

graphite-app bot changed the base branch from graphite-base/10074 to main March 28, 2025 04:30

graphite-app bot force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from 50b2970 to dde0a96 Compare March 28, 2025 04:30

Dunqing force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from dde0a96 to 51660e6 Compare March 28, 2025 05:18

Dunqing mentioned this pull request Mar 28, 2025

feat(semantic): check redeclaration of function declaration and class declaration #10093

Merged

This was referenced Mar 28, 2025

refactor(semantic): align handling of declaring symbol for class with TypeScript #10094

Merged

feat(semantic): add symbol_id for declare class binding #10095

Merged

graphite-app bot force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from 51660e6 to 0b5161c Compare March 28, 2025 07:25

graphite-app bot force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from 0b5161c to 5f8c64c Compare March 28, 2025 07:27

graphite-app bot force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from 5f8c64c to 370266c Compare March 28, 2025 07:32

graphite-app bot merged commit 370266c into main Mar 28, 2025
28 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 28, 2025

graphite-app bot deleted the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch March 28, 2025 07:42

This was referenced Apr 1, 2025

release(oxlint): v0.16.4 #10155

Merged

release(crates): v0.62.0 #10158

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(semantic): check redeclaration of variable declaration and function declaration in the block scope #10074

feat(semantic): check redeclaration of variable declaration and function declaration in the block scope #10074

Uh oh!

Dunqing commented Mar 27, 2025 •

edited

Loading

Uh oh!

Dunqing commented Mar 27, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

graphite-app bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(semantic): check redeclaration of variable declaration and function declaration in the block scope #10074

feat(semantic): check redeclaration of variable declaration and function declaration in the block scope #10074

Uh oh!

Conversation

Dunqing commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dunqing commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #10074 will not alter performance

Summary

Uh oh!

Uh oh!

graphite-app bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dunqing commented Mar 27, 2025 •

edited

Loading

Dunqing commented Mar 27, 2025 •

edited

Loading

codspeed-hq bot commented Mar 27, 2025 •

edited

Loading

graphite-app bot commented Mar 28, 2025 •

edited

Loading