feat(semantic): add `symbol_id` for declare function binding #10078

Dunqing · 2025-03-27T12:48:39Z

We had assumed Semantic adds a symbol id for symbol_id field that AST has, but declare function and declare class are exceptions, which would cause panicking somewhere. Add symbol id for declare function to fix the factor for panic.

Dunqing · 2025-03-27T12:49:05Z

feat(semantic): add symbol_id for declare class binding #10095
refactor(semantic): align handling of declaring symbol for class with TypeScript #10094
feat(semantic): check redeclaration of function declaration and class declaration #10093
feat(semantic): add symbol_id for declare function binding #10078 👈 (View in Graphite)
refactor(semantic): align handling of declaring symbol for function with TypeScript #10086
feat(semantic): check redeclaration of variable declaration and function declaration in the block scope #10074
fix(semantic): define a variable in a function expression whose name is the same as the function name which is considered a redeclaration #10077
refactor(semantic)!: store symbol information as the first entry in symbol_declarations when it is redeclared #10062
feat(semantic/scoping): add declaration and flags fields for Redeclaraion #10060
feat(semantic): introduce Redeclaraion for Scoping::symbol_declarations #10059
perf(semantic): use FxHashMap to replace IndexVec for symbol_redeclarations #10058
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-03-27T12:57:22Z

CodSpeed Instrumentation Performance Report

Merging #10078 will not alter performance

_{Comparing 03-27-feat_semantic_add_symbol_id_for_declare_function_binding (84a3490) with main (c903e42)}

Summary

✅ 33 untouched benchmarks

crates/oxc_linter/src/rules/eslint/no_unused_vars/ignored.rs

crates/oxc_semantic/src/binder.rs

…ion declaration in the block scope (#10074) close: #10050 close: #10051 close: #10055 close: #10056 This PR causes a lot of test262 tests to fail, all are expected. The reason is that the test262 test runner has a little incorrect, see #10057. And also produces a lot of duplicate errors, which will be removed in #10078.

graphite-app · 2025-03-29T14:04:18Z

Merge activity

Mar 29, 10:04 AM EDT: Boshen added this pull request to the Graphite merge queue.
Mar 29, 10:26 AM EDT: A user merged this pull request with the Graphite merge queue.

part of #7278 and #7951 We had assumed `Semantic` adds a symbol id for `symbol_id` field that AST has, but `declare function` and `declare class` are exceptions, which would cause panicking somewhere. Add symbol id for `declare function` to fix the factor for panic.

Part of #7278 and #7951, and the same as #10078 but for `declare class`

github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Mar 27, 2025

Dunqing mentioned this pull request Mar 27, 2025

fix(semantic): define a variable in a function expression whose name is the same as the function name which is considered a redeclaration #10077

Merged

Dunqing force-pushed the 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope branch from 1c741db to e81ae1e Compare March 27, 2025 14:12

Dunqing force-pushed the 03-27-feat_semantic_add_symbol_id_for_declare_function_binding branch 2 times, most recently from faf8870 to 93aeabc Compare March 27, 2025 14:34

Dunqing commented Mar 27, 2025

View reviewed changes

crates/oxc_linter/src/rules/eslint/no_unused_vars/ignored.rs Show resolved Hide resolved

Dunqing commented Mar 27, 2025

View reviewed changes

crates/oxc_semantic/src/binder.rs Outdated Show resolved Hide resolved

Dunqing changed the base branch from 03-27-feat_semantic_check_redeclaration_of_variable_declaration_and_function_declaration_in_the_block_scope to graphite-base/10078 March 28, 2025 00:59

Dunqing force-pushed the 03-27-feat_semantic_add_symbol_id_for_declare_function_binding branch from 93aeabc to ccc8c9d Compare March 28, 2025 00:59

Dunqing changed the base branch from graphite-base/10078 to 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_function_with_typescript March 28, 2025 00:59

Dunqing mentioned this pull request Mar 28, 2025

refactor(semantic): align handling of declaring symbol for function with TypeScript #10086

Merged

Dunqing marked this pull request as ready for review March 28, 2025 01:42

Dunqing requested a review from Boshen as a code owner March 28, 2025 01:42

graphite-app bot force-pushed the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_function_with_typescript branch from c29f055 to 132631b Compare March 28, 2025 04:30

graphite-app bot requested a review from overlookmotel as a code owner March 28, 2025 04:30

graphite-app bot force-pushed the 03-27-feat_semantic_add_symbol_id_for_declare_function_binding branch from ccc8c9d to ffc5dbc Compare March 28, 2025 04:31

Dunqing force-pushed the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_function_with_typescript branch from 132631b to 7116b2c Compare March 28, 2025 05:18

Dunqing force-pushed the 03-27-feat_semantic_add_symbol_id_for_declare_function_binding branch from ffc5dbc to a514509 Compare March 28, 2025 05:19

This was referenced Mar 28, 2025

feat(semantic): check redeclaration of function declaration and class declaration #10093

Merged

refactor(semantic): align handling of declaring symbol for class with TypeScript #10094

Merged

Dunqing mentioned this pull request Mar 28, 2025

feat(semantic): add symbol_id for declare class binding #10095

Merged

graphite-app bot changed the base branch from 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_function_with_typescript to graphite-base/10078 March 28, 2025 07:26

graphite-app bot force-pushed the graphite-base/10078 branch from 7116b2c to 5d829c2 Compare March 28, 2025 07:44

graphite-app bot force-pushed the 03-27-feat_semantic_add_symbol_id_for_declare_function_binding branch from a514509 to 6e5fca2 Compare March 28, 2025 07:44

graphite-app bot changed the base branch from graphite-base/10078 to main March 28, 2025 07:45

graphite-app bot force-pushed the 03-27-feat_semantic_add_symbol_id_for_declare_function_binding branch from 6e5fca2 to 268a827 Compare March 28, 2025 07:45

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 29, 2025

graphite-app bot force-pushed the 03-27-feat_semantic_add_symbol_id_for_declare_function_binding branch from 268a827 to 84a3490 Compare March 29, 2025 14:15

graphite-app bot pushed a commit that referenced this pull request Mar 29, 2025

feat(semantic): add symbol_id for declare class binding (#10095)

f6d181f

Part of #7278 and #7951, and the same as #10078 but for `declare class`

graphite-app bot merged commit 84a3490 into main Mar 29, 2025
28 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 29, 2025

graphite-app bot deleted the 03-27-feat_semantic_add_symbol_id_for_declare_function_binding branch March 29, 2025 14:26

This was referenced Apr 1, 2025

release(oxlint): v0.16.4 #10155

Merged

release(crates): v0.62.0 #10158

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(semantic): add `symbol_id` for declare function binding #10078

feat(semantic): add `symbol_id` for declare function binding #10078

Uh oh!

Dunqing commented Mar 27, 2025 •

edited

Loading

Uh oh!

Dunqing commented Mar 27, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Mar 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(semantic): add symbol_id for declare function binding #10078

feat(semantic): add symbol_id for declare function binding #10078

Uh oh!

Conversation

Dunqing commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dunqing commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #10078 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Mar 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(semantic): add `symbol_id` for declare function binding #10078

feat(semantic): add `symbol_id` for declare function binding #10078

Dunqing commented Mar 27, 2025 •

edited

Loading

Dunqing commented Mar 27, 2025 •

edited

Loading

codspeed-hq bot commented Mar 27, 2025 •

edited

Loading

graphite-app bot commented Mar 29, 2025 •

edited

Loading