-
-
Notifications
You must be signed in to change notification settings - Fork 778
refactor(semantic)!: store symbol information as the first entry in symbol_declarations when it is redeclared
#10062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
03-26-refactor_semantic_store_symbol_information_as_the_first_entry_in_symbol_declarations_when_it_is_redeclared
Mar 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symbol_declarations when it is redeclared
This was referenced Mar 26, 2025
Member
Author
CodSpeed Instrumentation Performance ReportMerging #10062 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
260a46e to
9e5ecec
Compare
This was referenced Mar 27, 2025
Contributor
Merge activity
|
…symbol_declarations` when it is redeclared (#10062) This PR aims to solve a problem where the flags of a symbol would merge its redeclaration symbol flags, which means we can't know what the flags of the first definition is. This PR changes to when a symbol is redeclared, store the symbol itself as the first entry of `symbol_redeclarations`, from which we can know the `flags` of every definition.
18689d0 to
528469e
Compare
9e5ecec to
cd1f035
Compare
Base automatically changed from
03-26-feat_semantic_scoping_add_declaration_and_flags_fields_for_symbol_declarations
to
main
March 28, 2025 04:25
This was referenced Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-linter
Area - Linter
A-semantic
Area - Semantic
A-transformer
Area - Transformer / Transpiler
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR aims to solve a problem where the flags of a symbol would merge its redeclaration symbol flags, which means we can't know what the flags of the first definition is.
This PR changes to when a symbol is redeclared, store the symbol itself as the first entry of
symbol_redeclarations, from which we can know theflagsof every definition.