Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 28, 2025

Part of #7278 and #7951, and the same as #10078 but for declare class

Copy link
Member Author

Dunqing commented Mar 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 28, 2025

CodSpeed Instrumentation Performance Report

Merging #10095 will not alter performance

Comparing 03-28-feat_semantic_add_symbol_id_for_declare_class_binding (f6d181f) with 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_class_with_typescript (dc3602c)

Summary

✅ 33 untouched benchmarks

@graphite-app graphite-app bot force-pushed the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_class_with_typescript branch from e31c7ee to 670a60d Compare March 28, 2025 07:45
@graphite-app graphite-app bot force-pushed the 03-28-feat_semantic_add_symbol_id_for_declare_class_binding branch from 6fabf6e to 7789e12 Compare March 28, 2025 07:46
@Dunqing Dunqing marked this pull request as ready for review March 28, 2025 07:48
@Dunqing Dunqing requested a review from Boshen as a code owner March 28, 2025 07:48
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 29, 2025
Copy link
Member

Boshen commented Mar 29, 2025

Merge activity

  • Mar 29, 10:04 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 29, 10:04 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Mar 29, 10:31 AM EDT: A user merged this pull request with the Graphite merge queue.

Part of #7278 and #7951, and the same as #10078 but for `declare class`
@graphite-app graphite-app bot force-pushed the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_class_with_typescript branch from 670a60d to dc3602c Compare March 29, 2025 14:16
@graphite-app graphite-app bot force-pushed the 03-28-feat_semantic_add_symbol_id_for_declare_class_binding branch from 7789e12 to f6d181f Compare March 29, 2025 14:16
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 29, 2025
Base automatically changed from 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_class_with_typescript to main March 29, 2025 14:30
@graphite-app graphite-app bot merged commit f6d181f into main Mar 29, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 03-28-feat_semantic_add_symbol_id_for_declare_class_binding branch March 29, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants