Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 28, 2025

Same as #10086 but for class

Copy link
Member Author

Dunqing commented Mar 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 28, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 28, 2025

CodSpeed Instrumentation Performance Report

Merging #10094 will not alter performance

Comparing 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_class_with_typescript (dc3602c) with 03-28-feat_semantic_check_redeclaration_of_function_declaration_and_class_declaration (9b92919)

Summary

✅ 33 untouched benchmarks

@graphite-app graphite-app bot force-pushed the 03-28-feat_semantic_check_redeclaration_of_function_declaration_and_class_declaration branch from 3a6265c to 30e4882 Compare March 28, 2025 07:45
@graphite-app graphite-app bot force-pushed the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_class_with_typescript branch from e31c7ee to 670a60d Compare March 28, 2025 07:45
@Dunqing Dunqing marked this pull request as ready for review March 28, 2025 07:47
@Dunqing Dunqing requested a review from Boshen as a code owner March 28, 2025 07:47
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 29, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 29, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Mar 29, 2025
… declaration (#10093)

Preparing for #10094. This will lead to a duplicate error of redeclaration of function and class, but it will be removed in #10094.
@graphite-app graphite-app bot force-pushed the 03-28-feat_semantic_check_redeclaration_of_function_declaration_and_class_declaration branch from 30e4882 to 9b92919 Compare March 29, 2025 14:15
@graphite-app graphite-app bot force-pushed the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_class_with_typescript branch from 670a60d to dc3602c Compare March 29, 2025 14:16
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 29, 2025
Base automatically changed from 03-28-feat_semantic_check_redeclaration_of_function_declaration_and_class_declaration to main March 29, 2025 14:28
@graphite-app graphite-app bot merged commit dc3602c into main Mar 29, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 03-28-refactor_semantic_align_handling_of_declaring_symbol_for_class_with_typescript branch March 29, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants